Remove /images/ endpoint, replaced by s3 logos #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
frontend
nrjadkry
approved these changes
Nov 28, 2023
|
I just noticed I need to update the fallback image for the frontend. I think it should be part if the frontend assets, committed to the repo (the map with the magnifying glass). |
spwoodcock
force-pushed
the
refactor/remove-img-endpoint
branch
from
ea03789 to
d6cb0c8
Compare
spwoodcock
temporarily deployed
to
1013/merge
GitHub Actions
Inactive
nischalstha9
pushed a commit
to naxa-developers/fmtm
that referenced
this pull request
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The /images/ endpoint is no longer required.
The org logos are stored in S3 thanks to @nrjadkry.
I removed the endpoint & updated the frontend to load the returned org urls from S3.
Note: currently the dev/staging server logos don't display. This PR will fix it.